Deprecate rowID and primaryKey in grid interfaces #13427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddincheva
added
version: 16.1.x
🛠️ status: in-development
14 tasks
…into ddincheva/deprecatedPropRemovalMaster-16.1
…into ddincheva/deprecatedPropRemovalMaster-16.1
…github.com/IgniteUI/igniteui-angular into ddincheva/deprecatedPropRemovalMaster-16.1
ddincheva
removed
the
🛠️ status: in-development
|
@damyanpetev Reminder :) |
|
@ddincheva will shortly resolve the conflicts. |
…into ddincheva/deprecatedPropRemovalMaster-16.1
damyanpetev
reviewed
Feb 5, 2024
| @@ -18,6 +18,7 @@ import { NgTemplateOutlet, NgIf, NgFor, NgStyle, NgClass } from '@angular/common | |||
| }) | |||
| export class IgxGridRowComponent extends IgxRowDirective { | |||
|
|
|||
| // TODO, is this public? | |||
damyanpetev
reviewed
Feb 5, 2024
CHANGELOG.md
Outdated
| @@ -22,6 +22,15 @@ All notable changes for each version of this project will be documented in this | |||
| - Unified logic for vertical and horizontal virtualization such as - caching, updating, max browser size exceeding. | |||
| - Addded new method - `addScroll` that can shift the scroll thumb by the specified amount in pixels (negative number to scroll to previous, positive to scroll next). Similar to `addScrollTop` but works for both vertical and horizontal virtualization. | |||
|
|
|||
|
|
|||
| - `IgxGrid`, `IgxTreeGrid`, `IgxHierarchicalGrid`, `IgxPivotGrid` | |||
There was a problem hiding this comment.
All of those events are not really available for the IgxPivotGrid
damyanpetev
previously approved these changes
Feb 5, 2024
damyanpetev
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10617
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)