Revert "Use eye transform instead of translation in external_vr" #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bb776dd. This was an attempt to fix some distortions we were seeing in some devices. However it didn't make any difference in the end as the problem was in some other place. In practice it was changing nothing so we could live with it but the fact is that it's a barrier for new developers because it forces devs to build our fork of Gecko to support WebXR sessions (as we were bumping the version of the protocol used by GeckoView).
|
BTW note that we'll have to revert also the Gecko patch in our fork |
|
I'm closing this as we are not sure we want to land this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bb776dd.
This was an attempt to fix some distortions we were seeing in some devices.
However it didn't make any difference in the end as the problem was in some
other place. In practice it was changing nothing so we could live with it
but the fact is that it's a barrier for new developers because it forces
devs to build our fork of Gecko to support WebXR sessions (as we were
bumping the version of the protocol used by GeckoView).