Skip to content

Commit

Permalink
Remove useless definition from IDBDatabase.idl
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=231997

Reviewed by Chris Dumez.

DOMStringList is also iterable in WebKit now, so we don't need to keep this definition for compatibility (see
w3c/IndexedDB#85 (comment)).

Covered by existing test storage/indexeddb/transaction-basics.html, which verifies that DOMStringList can be
argument for IDBDatabase.transaction().

* Modules/indexeddb/IDBDatabase.idl:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@284550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
[email protected] committed Oct 20, 2021
1 parent e2dcdee commit 6d59726
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
15 changes: 15 additions & 0 deletions Source/WebCore/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
2021-10-20 Sihui Liu <[email protected]>

Remove useless definition from IDBDatabase.idl
https://bugs.webkit.org/show_bug.cgi?id=231997

Reviewed by Chris Dumez.

DOMStringList is also iterable in WebKit now, so we don't need to keep this definition for compatibility (see
https://github.com/w3c/IndexedDB/issues/85#issuecomment-272587319).

Covered by existing test storage/indexeddb/transaction-basics.html, which verifies that DOMStringList can be
argument for IDBDatabase.transaction().

* Modules/indexeddb/IDBDatabase.idl:

2021-10-20 Sihui Liu <[email protected]>

Share code between JSDOMIterator and JSDOMAsyncIterator
Expand Down
4 changes: 0 additions & 4 deletions Source/WebCore/Modules/indexeddb/IDBDatabase.idl
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@
attribute EventHandler onclose;
attribute EventHandler onerror;
attribute EventHandler onversionchange;

// Non-standard: This is not part of the spec, but is needed for compatibility.
// See https://github.com/w3c/IndexedDB/issues/85
IDBTransaction transaction(DOMStringList storeNames, optional IDBTransactionMode mode = "readonly");
};

dictionary IDBObjectStoreParameters {
Expand Down

0 comments on commit 6d59726

Please sign in to comment.