wl: Prefer SSD via zxdg_decoration_manager_v1 #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperezdc
requested review from
psaavedra,
alexgcastro,
csaavedra and
carlosgcampos
|
Screenshot, running under Labwc:
|
aperezdc
force-pushed
the
aperezdc/wl-xdg-decoration
branch
from
9ee9e6b to
210440d
Compare
aperezdc
force-pushed
the
aperezdc/wl-xdg-decoration
branch
from
210440d to
3bff030
Compare
Ask compositors that support the zxdg_decoration_manager_v1_interface protocol to provide server-side decorations (SSD). This way it is more likely that the Cog surfaces will have window decorations. Note that compositors will still hide the decorations of fullscreen surfaces, but maximized ones will keep them, and this is the expected behaviour. Tested on Sway and Labwc, and should work in most (if not all) wlroots based compositors.
aperezdc
force-pushed
the
aperezdc/wl-xdg-decoration
branch
from
3bff030 to
ca4c600
Compare
psaavedra
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask compositors that support the
zxdg_decoration_manager_v1_interfaceprotocol to provide server-side decorations (SSD). This way it is more likely that the Cog surfaces will have window decorations. Note that compositors will still hide the decorations of fullscreen surfaces, but maximized ones will keep them, and this is the expected behaviour. Tested on Sway and Labwc, and should work in most (if not all) wlroots based compositors.