core: Remove view and viewport handling from CogShell #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperezdc
force-pushed
the
aperezdc/multiple-views
branch
2 times, most recently
from
f14ad9a to
8519a74
Compare
Remove handling of viewports and views from CogShell. Tracking live viewports can be done using CogPlatform since #683 and platform plug-ins no longer depend on CogShell for that. The following are no longer needed in CogShell: - The :web-view and :viewport properties, and their accessors. - The ::create-view and ::create-viewport signals. - The .create_view() virtual function and its default implementation. - The cog_shell_add_viewport(), cog_shell_remove_viewport(), cog_shell_get_n_viewports(), and cog_shell_get_nth_viewport() methods. As a side effect of the above removals, the examples have been changed to have them create their views using cog_view_new() instead of relying on the default implementation of the CogShell.create_view() virtual function. The launcher also needed a number of changes, which now manages itself a viewport as it cannot rely on the shell for that. Some code was moved around to accommodate creation of the view in cog_launcher_startup() without relying on the CogShell::create-view signal, and similarly for web view creation when running in automation mode. There are more opportunities for further simplifications that would be better done in separate patches: this one focuses on the minimum amount of changes needed to get view and viewport handling out of CogShell.
Remove the CogShell.startup() and CogShell.shutdown() virtual functions, which are not needed anymore now that CogShell does not know anything about web views nor viewports.
aperezdc
force-pushed
the
aperezdc/multiple-views
branch
from
8519a74 to
3477cc0
Compare
|
tested on my rpi3. |
psaavedra
approved these changes
Jan 3, 2024
|
Thanks @psaavedra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove handling of viewports and views from
CogShell. Tracking live viewports can be done usingCogPlatformsince #683 and platform plug-ins no longer depend onCogShellfor that. The following are no longer needed inCogShell::web-viewand:viewportproperties, and their accessors.::create-viewand::create-viewportsignals..create_view()virtual function and its default implementation.cog_shell_add_viewport(),cog_shell_remove_viewport(),cog_shell_get_n_viewports(), andcog_shell_get_nth_viewport()methods.As a side effect of the above removals, the examples have been changed to have them create their views using
cog_view_new()instead of relying on the default implementation of theCogShell.create_view()virtual function.The launcher also needed a number of changes, which now manages itself a viewport as it cannot rely on the shell for that. Some code was moved around to accommodate creation of the view in
cog_launcher_startup()without relying on theCogShell::create-viewsignal, and similarly for web view creation when running in automation mode.There are more opportunities for further simplifications that would be better done in separate patches: this one focuses on the minimum amount of changes needed to get view and viewport handling out of
CogShell.