Update cursor on wl, x11 and gtk4 #605
Conversation
joantolo
force-pushed
the
update-cursor
branch
2 times, most recently
from
9cb484e to
934f99b
Compare
There was a problem hiding this comment.
@joantolo I have a couple of comments, could you please take a look? While at it, please use the data/check-style script to ensure the patch follows the same coding style as the rest of the source code.
Regarding the usage of the signal, I agree that it would be ideal to plumb WebKit's PageClientImpl::setCursor() instead to make it work for WPE; but that will need either new public API either in libwpe or in WPE WebKit itself, which would be way more effort.
In the meantime, I would be more than happy to have this implementation merged in Cog, because it's better than nothing. Thanks for working on this!
joantolo
force-pushed
the
update-cursor
branch
from
934f99b to
a41c3a9
Compare
There was a problem hiding this comment.
@joantolo This is looking good, there's only one last detail before we can merge this: we need to add libxcb-cursor-dev in the list of packages to install during the CI builds, in .github/workflows/ci-native.yml.
If you could have a moment to rebase the patch and do that small change, then we can merge this. Thanks again!
joantolo
force-pushed
the
update-cursor
branch
from
a41c3a9 to
84bbb83
Compare
This definitions are used when creating cursors for the different platforms using the names. For each cursor type there is an array of names sorted by preference.
The cursor is updated from mouse-target-changed signal. It can be: hand, text or left_ptr. To get each cursor it is used the cursor_theme_get_cursor func with the cursor_names definitions.
The cursor is updated from mouse-target-changed signal. It can be: hand, text or left_ptr. This is done using the xcb cursor library. To get each cursor it is using the xcb_cursor_load_cursor func with the cursor_names definitions.
The cursor is updated from mouse-target-changed signal. It can be: hand, text or left_ptr. To get each cursor it is using the gdk_cursor_new_from_name func with the cursor_names definitions.
joantolo
force-pushed
the
update-cursor
branch
from
84bbb83 to
c51983b
Compare
|
Added |
These changes allow the cursor to be updated when hovering on links or on input text fields. And the rest with the default pointer.
From a small conversation with @aperezdc on matrix, the idea was to create a signal at
WebKitWebViewand connect to it. However, the 'mouse-target-changed' signal already gives some hovering mouse info, but not all. For instance, that signal doesn't inform when hovering over text.As a first step, I've used '
mouse-target-changed' signal.A better signal could be emitted from
PageClientImpl::setCursor.But when debugging cog, I see that
setCursorisn't used, I don't know why.The next step would be to use the
setCursorto expose a signal with all cursor changes and add more cursor names.Fixes the cursor part of #594.