Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the possibility to configure the length of the nonce and the state #305

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

rollagnier
Copy link
Contributor

Added the possibility to configure the length of the nonce and the state
Added the raw response if HttpStatusCode is not OK (redeem code for tokens)

Added the raw response if HttpStatusCode is not OK (redeem code for tokens)
@leastprivilege
Copy link
Contributor

Sorry for closing.

Could you give me some reasoning for these changes?

@blushingpenguin
Copy link
Contributor

One motivation for configuring the state length is NetSuite which requires a 24 character state parameter for no apparent reason:
https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_158081944642.html

state | The length of the state parameter must be between 24 and 1024 characters. Valid characters are all printable ASCII characters.

They really do enforce that.

@leastprivilege
Copy link
Contributor

Two thoughts

a) nonce is not required anymore since Hybrid flow is not supported anymore
b) there should be a lower bound for the state length

@leastprivilege
Copy link
Contributor

OK - nonce removed via #328

@rollagnier
Copy link
Contributor Author

Hello,

My client has developed his own identity management and authentication tool. The nonce and the state must have a minimum length. For example, the US government recommends at least 22 characters (https://developers.login.gov/oidc/).

Best Regards,
Remi Ollagnier

# Conflicts:
#	src/OidcClient/AuthorizeClient.cs
@leastprivilege leastprivilege merged commit 2798d22 into IdentityModel:main Jul 16, 2021
@leastprivilege
Copy link
Contributor

ok. thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants