Version 2.11.0+ compatibility #11
Conversation
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @MegaphoneJon
|
|
I've signed the CLA. |
|
@cla-bot check |
|
I can confirm that this fixed the problem for me. |
module.info
Outdated
| @@ -4,4 +4,4 @@ Description: Generic Trouble Ticket System connection module | |||
| This module allows to easily link issue/ticket numbers in your Icinga | |||
| acknowledgement or downtime comments. Configure a pattern matching | |||
| your ticket numbers and a URL with placeholders. Please note that | |||
| Icinga Web 2 version 2.3.0 is required at least to run this module. | |||
| Icinga Web 2 version 2.11.0 is required at least to run this module. | |||
There was a problem hiding this comment.
Hi,
You do not have to change the version requirement for Icinga Web 2. This hook is also available in earlier versions and even in v2.3.0.
Same here. Thank you for this PR. |
Import `Icinga\Application\Hook\TicketHook` instead of `Icinga\Web\Hook\TicketHook` in `Ticket` class. As `Icinga\Web\Hook\TicketHook` has been deprecated since Icinga Web 2 v2.11.0. Co-authored-by: Ravi Kumar Kempapura Srinivasa <[email protected]>
I don't know enough about the Icingaweb ecosystem to know if we need to provide backward compatibility, or whether we can tag a new release that's only compatible w/ 2.11.0+ - so this may be insufficient. But at least this should be helpful to anyone else who has Icingaweb2 troubles on upgrade to 2.11.
fixes #10