Render Icinga config helpers with safe globals access #1654
Conversation
globals[key] works, although it wasn't documented how it behaves in the case when this field doesn't exist. Previously this has been a dictionary which silently returns null if the key doesn't exist. With v2.10, globals turned into a namespace which throws an error if not existing (which is the correct behaviour). In order to avoid configuration errors with 2.10, this is changed into `contains()` which has been sitting in dictionaries since 2014. So this patch ensures compatibility with older versions as well.
|
Looks good to me, thanks for the pull request and the related details. 2014 means that Agents running 2.6 are safe I guess. @lazyfrosch: if you have the chance to give 2.6 a quick test this would be cool, otherwise I'd blindly trust @dnsmichi and merge to master. |
|
Anything since 2.4 should work here, |
|
Thanks again! |
|
Since this problem comes out more often, I've discussed it again with @lippserd ... the patch for the Director is safe, still we need to take care about existing deployments where this would stop with 2.10. The patch for the Director is fine and safe, but we don't need a release for it now. I'll like a PR for 2.10 which solves the access problem, and allows for smooth upgrading. |
Examples: ``` globals["abc"] globals.def ``` The patch for the Icinga Director unfortunately only solves the master, and as discussed with @lippserd we need to ensure that satellites and clients with 2.10 can be restarted without any errors from deployed configuration. refs #6509 refs Icinga/icingaweb2-module-director#1654
globals[key] works, although it wasn't documented how it
behaves in the case when this field doesn't exist.
Previously this has been a dictionary which silently returns
null if the key doesn't exist. With v2.10, globals turned
into a namespace which throws an error if not existing (which is
the correct behaviour).
In order to avoid configuration errors with 2.10, this is changed
into
contains()which has been sitting in dictionaries since 2014.So this patch ensures compatibility with older versions as well.