Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Add missing indices to hostgroup and servicegroup #616

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Jul 11, 2023

These new indices make these tables consistent with usergroup.

fixes #615

@nilmerg nilmerg self-assigned this Jul 11, 2023
@cla-bot cla-bot bot added the cla/signed label Jul 11, 2023
@julianbrost julianbrost added this to the 1.2.0 milestone Jul 26, 2023
@julianbrost
Copy link
Contributor

Change looks fine to me in general. Will you do it for PostgreSQL as well and also resolve the merge conflict while doing so?

@julianbrost julianbrost force-pushed the fix/indexes-for-host-and-service-group-615 branch from 759eadc to ee4697b Compare August 1, 2023 14:50
@julianbrost julianbrost force-pushed the fix/indexes-for-host-and-service-group-615 branch from ee4697b to de09001 Compare August 1, 2023 14:51
@julianbrost julianbrost marked this pull request as ready for review August 1, 2023 14:56
@julianbrost julianbrost requested a review from Al2Klimov August 1, 2023 14:57
Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine in general, but...

schema/mysql/schema.sql Show resolved Hide resolved
@julianbrost julianbrost requested a review from Al2Klimov August 2, 2023 08:40
@julianbrost julianbrost merged commit 7c7ba9f into master Aug 2, 2023
@julianbrost julianbrost deleted the fix/indexes-for-host-and-service-group-615 branch August 2, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Less indexes on hostgroup and servicegroup than on usergroup
3 participants