-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for migration tool #536
Conversation
f3f98d7
to
e938669
Compare
1. Moves the example config to a separate file one can just download. 2. Establishes some kind of standard workflow for the migration.
e938669
to
ed9ae66
Compare
sections of the configuration. | ||
|
||
Both the IDO and Icinga DB support MySQL and PostgreSQL. You can migrate from | ||
and to both types, including from one type to the other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still like the idea to get this fact underlined...
|
||
# IDO database | ||
ido: | ||
type: mysql # or "pgsql" for PostgreSQL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... by switching the DB types here. :)
(After all this one's migrating from IPv4 to IPv6 as well.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we support both databases, I don't think we should incentivize a switch here. So if a user has the desire to switch, they will probably look for it, others may be confused why the example migrates from MySQL to PostgreSQL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I think we should incentivize a switch – from PostgreSQL to MySQL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It would make no sense for Icinga DB to support PostgreSQL if we would recommend to migrate away from it.
TODO
Figure out if we want to keep the endpoint setting or just use NULL (context), then either write documentation for it or remove it altogether.endpoint
option in other PR (cmd/icingadb-migrate: avoid unnecessary config option #541)