Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example config and docs #497

Merged
merged 25 commits into from
Jun 29, 2022
Merged

Update example config and docs #497

merged 25 commits into from
Jun 29, 2022

Conversation

lippserd
Copy link
Member

@lippserd lippserd commented Jun 7, 2022

Also, the default Redis port is now set to 6380. Please ask @bobapple how to build and view the documentation.

@lippserd lippserd added this to the 1.0.0 milestone Jun 7, 2022
@cla-bot cla-bot bot added the cla/signed label Jun 7, 2022
@lippserd lippserd requested a review from julianbrost June 7, 2022 12:18
@lippserd lippserd force-pushed the example-config-and-docs branch from 6bb0ef3 to 303427c Compare June 7, 2022 12:27
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the numbering in doc/ changed so that there is a gap now?

doc/02-Installation.md Outdated Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
doc/01-About.md Outdated Show resolved Hide resolved
doc/01-About.md Outdated Show resolved Hide resolved
doc/02-Installation.md Outdated Show resolved Hide resolved
@lippserd
Copy link
Member Author

lippserd commented Jun 7, 2022

Why was the numbering in doc/ changed so that there is a gap now?

That’s by mistake.

@lippserd lippserd added the area/documentation Improvements or additions to documentation label Jun 7, 2022
@lippserd lippserd force-pushed the example-config-and-docs branch 4 times, most recently from ade11c2 to ec90966 Compare June 13, 2022 13:00
@lippserd lippserd force-pushed the example-config-and-docs branch from ec90966 to 85f0760 Compare June 15, 2022 11:52
@lippserd lippserd requested a review from julianbrost June 15, 2022 12:51
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want add some generic upgrade instruction that are valid for every release like applying database schema migrations (which is required for 1.0.0rc2 -> 1.0.0).

doc/01-About.md Outdated Show resolved Hide resolved
.github/workflows/version.yml Show resolved Hide resolved
doc/01-About.md Show resolved Hide resolved
doc/01-About.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
doc/02-Installation.md Outdated Show resolved Hide resolved
doc/03-Configuration.md Outdated Show resolved Hide resolved
@lippserd lippserd force-pushed the example-config-and-docs branch 6 times, most recently from b117fcb to 32d545b Compare June 22, 2022 10:08
@lippserd lippserd requested a review from julianbrost June 22, 2022 10:16
@lippserd
Copy link
Member Author

Since the doc branches are not merged yet, you need to manually use https://icinga.com/docs/icinga-db-web/docs/ for the Icinga DB Web doc links at the moment.

@lippserd lippserd force-pushed the example-config-and-docs branch 2 times, most recently from 672b99b to 8cb2fba Compare June 24, 2022 09:37
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that it's written down somewhere: in the images, there should only be one connection between Web and the database.

doc/05-Distributed-Setups.md Outdated Show resolved Hide resolved
doc/05-Distributed-Setups.md Outdated Show resolved Hide resolved
doc/05-Distributed-Setups.md Outdated Show resolved Hide resolved
@lippserd lippserd force-pushed the example-config-and-docs branch from 8cb2fba to 02998d8 Compare June 27, 2022 12:00
@lippserd lippserd requested a review from julianbrost June 27, 2022 12:16
@lippserd lippserd force-pushed the example-config-and-docs branch 2 times, most recently from 1612a53 to bfa4623 Compare June 28, 2022 19:37
@lippserd lippserd force-pushed the example-config-and-docs branch 2 times, most recently from 5349671 to 5a8b204 Compare June 29, 2022 12:46
@lippserd lippserd force-pushed the example-config-and-docs branch from 5a8b204 to 46d0e2b Compare June 29, 2022 13:42
@julianbrost julianbrost enabled auto-merge June 29, 2022 13:46
@julianbrost julianbrost linked an issue Jun 29, 2022 that may be closed by this pull request
15 tasks
@julianbrost julianbrost merged commit 85a7b6a into master Jun 29, 2022
@julianbrost julianbrost deleted the example-config-and-docs branch June 29, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation improvements
2 participants