Icinga DB feature: normalize *Command.arguments[*].{required,skip_key…

[Al2Klimov]

…,repeat_key} to boolean

At the moment, the Icinga DB feature will use that value as-is and serialize it to JSON, resulting in a crash in Icinga DB down the road because it expects a boolean.

fixes #9576
closes #9771

TODO

• test (@Al2Klimov)

[Al2Klimov]

ok?

[julianbrost]

This looks like the change I was expecting for that issue. So you can go ahead here.

(I wouldn't be opposed to a change like in #9771 if it warned instead of errored out, that could be a useful warning, but as that touches validation code, this would require looking into if/how other booleans would be affected by the change as well.)

[Al2Klimov]

Before

2023-05-24T16:01:17.591+0200	WARN	config-sync	Aborted config sync after 713.564505ms
2023-05-24T16:01:17.591+0200	FATAL	icingadb	json: cannot unmarshal number into Go value of type bool
can't unmarshal JSON into *bool
github.com/icinga/icingadb/internal.UnmarshalJSON
	/Users/aklimov/NET/WS/icingadb/internal/internal.go:47
github.com/icinga/icingadb/pkg/types.(*Bool).UnmarshalJSON
	/Users/aklimov/NET/WS/icingadb/pkg/types/bool.go:52
encoding/json.(*decodeState).literalStore
	/usr/local/Cellar/go/1.20.4/libexec/src/encoding/json/decode.go:872
encoding/json.(*decodeState).value
	/usr/local/Cellar/go/1.20.4/libexec/src/encoding/json/decode.go:388
encoding/json.(*decodeState).object
	/usr/local/Cellar/go/1.20.4/libexec/src/encoding/json/decode.go:775
encoding/json.(*decodeState).value
	/usr/local/Cellar/go/1.20.4/libexec/src/encoding/json/decode.go:374
encoding/json.(*decodeState).unmarshal
	/usr/local/Cellar/go/1.20.4/libexec/src/encoding/json/decode.go:181
encoding/json.Unmarshal
	/usr/local/Cellar/go/1.20.4/libexec/src/encoding/json/decode.go:108
github.com/icinga/icingadb/internal.UnmarshalJSON
	/Users/aklimov/NET/WS/icingadb/internal/internal.go:47
github.com/icinga/icingadb/pkg/icingaredis.CreateEntities.func1.1
	/Users/aklimov/NET/WS/icingadb/pkg/icingaredis/utils.go:56
golang.org/x/sync/errgroup.(*Group).Go.func1
	/Users/aklimov/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:57
runtime.goexit
	/usr/local/Cellar/go/1.20.4/libexec/src/runtime/asm_amd64.s:1598
can't unmarshal JSON into *v1.CheckcommandArgument
github.com/icinga/icingadb/internal.UnmarshalJSON
	/Users/aklimov/NET/WS/icingadb/internal/internal.go:47
github.com/icinga/icingadb/pkg/icingaredis.CreateEntities.func1.1
	/Users/aklimov/NET/WS/icingadb/pkg/icingaredis/utils.go:56
golang.org/x/sync/errgroup.(*Group).Go.func1
	/Users/aklimov/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:57
runtime.goexit
	/usr/local/Cellar/go/1.20.4/libexec/src/runtime/asm_amd64.s:1598

After

2023-05-24T16:05:26.054+0200	INFO	config-sync	Finished config sync in 113.349185ms