Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout for boost::asio::ssl::stream#async_shutdown() #7864

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Add timeout for boost::asio::ssl::stream#async_shutdown() #7864

merged 2 commits into from
Oct 19, 2020

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Feb 27, 2020 •
edited
Loading

fixes #7203

@Al2Klimov Al2Klimov added this to the 2.13.0 milestone Feb 27, 2020
@Al2Klimov Al2Klimov self-assigned this Feb 27, 2020
@Al2Klimov
Copy link
Member Author

Al2Klimov commented Feb 27, 2020 •
edited
Loading

Blocked by

@Al2Klimov Al2Klimov removed their assignment Feb 27, 2020
@Al2Klimov Al2Klimov marked this pull request as ready for review February 27, 2020 12:55
@lippserd lippserd mentioned this pull request Jun 17, 2020
Closed
@Al2Klimov Al2Klimov force-pushed the bugfix/icinga2-doesn-t-close-connections-7203 branch from 88a8b00 to 19c632e Compare June 17, 2020 08:34
@Al2Klimov Al2Klimov marked this pull request as draft June 29, 2020 13:17
@Al2Klimov Al2Klimov mentioned this pull request Sep 28, 2020
Closed
@Al2Klimov Al2Klimov added area/distributed Distributed monitoring (master, satellites, clients) bug Something isn't working labels Sep 28, 2020
@Al2Klimov Al2Klimov marked this pull request as ready for review September 28, 2020 13:44
@Al2Klimov Al2Klimov requested a review from julianbrost October 14, 2020 09:04
julianbrost
julianbrost reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with that code, so I'd prefer if someone else could review this.

@Al2Klimov Al2Klimov requested a review from N-o-X October 14, 2020 12:05
@Al2Klimov Al2Klimov merged commit a32c1bf into master Oct 19, 2020
@icinga-probot icinga-probot bot deleted the bugfix/icinga2-doesn-t-close-connections-7203 branch October 19, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost left review comments

@N-o-X N-o-X N-o-X approved these changes

Assignees
No one assigned
Labels
area/distributed Distributed monitoring (master, satellites, clients) bug Something isn't working
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Icinga2 doesn't close connections
3 participants
@Al2Klimov @julianbrost @N-o-X