Windows: Dynamically link Boost DLLs (avoid static linking) and ship them in sbin/ #7478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them in sbin/ This comes with the motivation to avoid bundling Boost context into our main binary. Whenever the context library allocates stack memory, or does something weird, we want to see this in the stack traces as origin from an external DLL and not the main icinga2.exe binary. TL;DR - this doesn't fix #7431 but makes debugging and development a bit more easy. And it follows the Windows approach with DLLs.
dnsmichi
added
area/setup
|
Thanks to @LordHepipud for the inspiration 👍 |
|
Has no direct impact on the issue. The tests currently fail because they do not find the DLLs in the build installation directory in |
|
It doesn't have an influence on the Windows crash itself, and requires build chain changes. As such, I'll look into this after 2.11 has been released. Therefore moved to 2.12. |
|
Does not add to the solution, and I don't see any benefit in the future either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes with the motivation to avoid bundling Boost context
into our main binary. Whenever the context library allocates
stack memory, or does something weird, we want to see this
in the stack traces as origin from an external DLL and not the
main icinga2.exe binary.
TL;DR - this doesn't solve #7431 but makes debugging and development
a bit more easy. And it follows the Windows approach with DLLs.