Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElasticsearchWriter: don't leak sockets #7020

Merged
merged 1 commit into from
Mar 18, 2019
Merged

ElasticsearchWriter: don't leak sockets #7020

merged 1 commit into from
Mar 18, 2019

Conversation

Al2Klimov
Copy link
Member

fixes #7018

@Al2Klimov Al2Klimov changed the title ElasticsearchWriter: don't leak sockets [WIP] ElasticsearchWriter: don't leak sockets Mar 15, 2019
@Al2Klimov
Copy link
Member Author

Al2Klimov commented Mar 15, 2019 •
edited
Loading

TODO

@Al2Klimov Al2Klimov self-assigned this Mar 15, 2019
@mcktr mcktr added the area/elastic Events to Elasticsearch label Mar 15, 2019
dnsmichi
dnsmichi reviewed Mar 18, 2019
View reviewed changes
lib/base/defer.hpp Outdated Show resolved Hide resolved
@dnsmichi dnsmichi added this to the 2.11.0 milestone Mar 18, 2019
@dnsmichi
Copy link
Contributor

@Al2Klimov please rebase.

@Al2Klimov Al2Klimov force-pushed the bugfix/elasticsearchwriter-oom-7018 branch from 3f6ea25 to e2205d8 Compare March 18, 2019 13:54
@Al2Klimov Al2Klimov removed their assignment Mar 18, 2019
@Al2Klimov Al2Klimov changed the title [WIP] ElasticsearchWriter: don't leak sockets ElasticsearchWriter: don't leak sockets Mar 18, 2019
@Al2Klimov Al2Klimov requested a review from dnsmichi March 18, 2019 13:55
@Al2Klimov Al2Klimov force-pushed the bugfix/elasticsearchwriter-oom-7018 branch from e2205d8 to b2e2b58 Compare March 18, 2019 14:09
@dnsmichi dnsmichi added the bug Something isn't working label Mar 18, 2019
@dnsmichi
Copy link
Contributor

Tests: #7018 (comment)

@dnsmichi dnsmichi merged commit 00b8fb1 into master Mar 18, 2019
@dnsmichi dnsmichi deleted the bugfix/elasticsearchwriter-oom-7018 branch March 18, 2019 15:39
@dnsmichi dnsmichi modified the milestones: 2.11.0, 2.10.4 Mar 19, 2019
@dnsmichi dnsmichi added the backported Fix was included in a bugfix release label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi dnsmichi approved these changes

Assignees
No one assigned
Labels
area/elastic Events to Elasticsearch backported Fix was included in a bugfix release bug Something isn't working
Projects
None yet
Milestone
2.10.4
Development

Successfully merging this pull request may close these issues.

ElasticsearchWriter not closing SSL connections on Icinga2 2.10.3.1
3 participants
@Al2Klimov @dnsmichi @mcktr