Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MYSQL_LIB to be specified by ENV variable #6107

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

MichalMMac
Copy link
Contributor

When I was compiling Icinga2 on macOS I run into minor issue when I had MariaDB client libs located on path (/opt/local/lib/mariadb/mysql/) FindMySQL.cmake was unable to find. It was not possible to specify MYSQL_LIB entirely by environment variable (like MYSQL_INCLUDE_DIR).

This PR allows to specify MYSQL_LIB path entirely from MYSQL_DIR environment variable.

Not sure if MYSQL_DIR is best var name for this case. It might be better to change it to something else ( maybe MYSQL_LIB_DIR?).

@gunnarbeutner gunnarbeutner self-requested a review February 26, 2018 07:07
@gunnarbeutner gunnarbeutner added the core/quality Improve code, libraries, algorithms, inline docs label Feb 26, 2018
@gunnarbeutner gunnarbeutner added this to the 2.9.0 milestone Feb 26, 2018
Copy link
Contributor

@gunnarbeutner gunnarbeutner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@gunnarbeutner
Copy link
Contributor

I'm OK with MYSQL_DIR. I don't think we're explicitly setting it anywhere atm but I'd rather not rename it - mainly to keep things in line with the upstream version of that file.

Merged. Thank you. :)

@gunnarbeutner gunnarbeutner merged commit e952302 into Icinga:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core/quality Improve code, libraries, algorithms, inline docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants