Ensure that HTTP/1.0 or Connection: close headers are properly discon…

…necting the client Test results: #6514 (comment) fixes #6514
Icinga · Oct 9, 2018 · 13239c3 · 13239c3
1 parent 051b3ba
commit 13239c3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/remote/httpresponse.cpp b/lib/remote/httpresponse.cpp
@@ -111,9 +111,6 @@ void HttpResponse::Finish()
 	}
 
 	m_State = HttpResponseEnd;
-
-	if (m_Request->ProtocolVersion == HttpVersion10 || m_Request->Headers->Get("connection") == "close")
-		m_Stream->Shutdown();
 }
 
 bool HttpResponse::Parse(StreamReadContext& src, bool may_wait)

diff --git a/lib/remote/httpserverconnection.cpp b/lib/remote/httpserverconnection.cpp
@@ -357,6 +357,13 @@ void HttpServerConnection::DataAvailableHandler()
 		}
 
 		m_RequestQueue.Enqueue(std::bind(&Stream::SetCorked, m_Stream, false));
+
+		/* Request finished, decide whether to explicitly close the connection. */
+		if (m_CurrentRequest.ProtocolVersion == HttpVersion10 ||
+			m_CurrentRequest.Headers->Get("connection") == "close") {
+			m_Stream->Shutdown();
+			close = true;
+		}
 	} else
 		close = true;