Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/creasty/defaults from 1.7.0 to 1.8.0 #60

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 13, 2024

Bumps github.com/creasty/defaults from 1.7.0 to 1.8.0.

Release notes

Sourced from github.com/creasty/defaults's releases.

v1.8.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/creasty/defaults](https://github.com/creasty/defaults) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/creasty/defaults/releases)
- [Commits](creasty/defaults@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/creasty/defaults
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 13, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Aug 13, 2024
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only relevant change seems to be creasty/defaults@v1.7.0...v1.8.0#diff-1b38200ba9e5f4b19a852f1c2a6938de5e1546bc2a02aaa431dc34c1574687e8 from creasty/defaults#46. The diff seems to be fine.

Unfortunately, we don't really have much tests in this regard (s/o to #41). An Icinga DB build against the icinga-go-library with this PR worked fine.

@yhabteab
Copy link
Member

yhabteab commented Aug 14, 2024

Isn't this PR basically the same as Icinga/icingadb#790? IIRC, we don't initialise slice of structs in any of our projects, so this shouldn't affect us in any way.

@yhabteab yhabteab merged commit f4dbc65 into main Aug 14, 2024
2 checks passed
@yhabteab yhabteab deleted the dependabot/go_modules/github.com/creasty/defaults-1.8.0 branch August 14, 2024 13:19
@oxzi oxzi added this to the 0.4.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants