Suggestion: Polykinded On + OnTarget class #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits functionality on
On
into a typeclass to allow adding new types that implement targets for it. The typeclass dispatches on a kind, so we can still have the general "Symbol implies HasField" behaviour. I then took advantage of that to add:Nth
type that can be used to index fields by their position, using GHC Generics.I can see how this may end up overcomplicating the design, but the end result looks nice to me. Any other field accessors will now only need to define a single instance.
I have very little experience with GHC Generics, so I don't know if there's a better way to write the code in
Deriving.On.Nth
.