feat: add WEBUI_PORT interpolation #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tigerinus Please take a look |
Codecov Report
@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 20.75% 20.76% +0.01%
==========================================
Files 29 29
Lines 4043 4060 +17
==========================================
+ Hits 839 843 +4
- Misses 3069 3081 +12
- Partials 135 136 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
|
This needs proper documentation. As reference for current/aspiring CasaOS app developers. |
Yes! I'm writing it here: IceWhaleTech/CasaOS-AppStore#187 |
raller1028
pushed a commit
to IceWhaleTech/CasaOS-AppStore
that referenced
this pull request
Aug 3, 2023
add two magic values to the application contributor documents to help the developer to get the most from casaos. the document is waiting for these PRs to be merged - IceWhaleTech/CasaOS-AppManagement#113 - IceWhaleTech/CasaOS-AppManagement#110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
The PR adds a new interpolation value. the interpolation is different from base interpolation. It only interpolates once when installing a new app and it will be written in yaml file(/var/lib/casasos/app).
Test Steps
usememosof the store.(the name is difference from official store)