Sourcery Starbot ⭐ refactored IceBotYT/lacrosse_view #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Sep 16, 2022
Comment on lines
+104
to
+128
| headers = {"Authorization": f"Bearer {self.token}"} | ||
|
|
||
| data: dict[str, Any] | ||
|
|
||
| locations_url = ( | ||
| "https://lax-gateway.appspot.com/" | ||
| "_ah/api/lacrosseClient/v1.1/active-user/locations" | ||
| ) | ||
| headers = {"Authorization": "Bearer " + self.token} | ||
|
|
||
| data: dict[str, Any] | ||
|
|
||
| if not self.websession: | ||
| async with aiohttp.ClientSession() as session: | ||
| async with session.get(locations_url, headers=headers) as response: | ||
| if response.status != 200: | ||
| raise HTTPError( | ||
| "Failed to get locations, status code: " | ||
| + str(response.status) | ||
| f"Failed to get locations, status code: {str(response.status)}" | ||
| ) | ||
|
|
||
| data = await response.json() | ||
| else: | ||
| async with self.websession.get(locations_url, headers=headers) as response: | ||
| if response.status != 200: | ||
| raise HTTPError( | ||
| "Failed to get locations, status code: " + str(response.status) | ||
| f"Failed to get locations, status code: {str(response.status)}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function LaCrosse.get_locations refactored with the following changes:
- Move assignment closer to its usage within a block (
move-assign-in-block) - Use f-string instead of string concatenation [×3] (
use-fstring-for-concatenation)
Comment on lines
-161
to
+181
| devices = list() | ||
| headers = {"Authorization": "Bearer " + self.token} | ||
| headers = {"Authorization": f"Bearer {self.token}"} | ||
|
|
||
| sensors_url = f"https://lax-gateway.appspot.com/_ah/api/lacrosseClient/v1.1/active-user/location/{str(location.id)}/sensorAssociations?prettyPrint=false" | ||
|
|
||
| sensors_url = ( | ||
| "https://lax-gateway.appspot.com/" | ||
| "_ah/api/lacrosseClient/v1.1/active-user/location/" | ||
| + str(location.id) | ||
| + "/sensorAssociations?prettyPrint=false" | ||
| ) | ||
| if not self.websession: | ||
| async with aiohttp.ClientSession() as session: | ||
| async with session.get(sensors_url, headers=headers) as response: | ||
| if response.status != 200: | ||
| raise HTTPError( | ||
| "Failed to get location, status code: " | ||
| + str(response.status) | ||
| ) | ||
| raise HTTPError(f"Failed to get location, status code: {str(response.status)}") | ||
| data = await response.json() | ||
| else: | ||
| async with self.websession.get(sensors_url, headers=headers) as response: | ||
| if response.status != 200: | ||
| raise HTTPError( | ||
| "Failed to get location, status code: " + str(response.status) | ||
| ) | ||
| raise HTTPError(f"Failed to get location, status code: {str(response.status)}") | ||
| data = await response.json() | ||
|
|
||
| aggregates = "ai.ticks.1" | ||
|
|
||
| devices = [] |
There was a problem hiding this comment.
Function LaCrosse.get_sensors refactored with the following changes:
- Move assignment closer to its usage within a block (
move-assign-in-block) - Replace list() with [] (
list-literal) - Use f-string instead of string concatenation [×8] (
use-fstring-for-concatenation) - Hoist statements out of for/while loops (
hoist-statement-from-loop)
Comment on lines
-265
to
+253
| headers = {"Authorization": "Bearer " + self.token} | ||
| headers = {"Authorization": f"Bearer {self.token}"} |
There was a problem hiding this comment.
Function LaCrosse.logout refactored with the following changes:
- Use f-string instead of string concatenation [×3] (
use-fstring-for-concatenation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: