Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper .sops extension for file without extension #51

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Add proper .sops extension for file without extension #51

merged 3 commits into from
Sep 7, 2022

Conversation

randrusiak
Copy link
Contributor

Story/Issue Link

Fixes #11

Background

Currently, if you add a file without an extension then ".sops" extension is added as a prefix. It looks strange and disallows adding a file with a local path for example ./file_no_ext.
I added a simple conditional which handle this case :)

Versioning

Patch version

Additional Requests to Reviewers

Tasks

  • Specs written
  • Manual testing

Copy link
Member

@onyxraven onyxraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple test cases to test the 'other' direction

tested locally and works. Thanks!

@onyxraven onyxraven merged commit 5a95df7 into Ibotta:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sopstool add fails on files without extensions
2 participants