-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bottom navigation for mobile added #150
base: master
Are you sure you want to change the base?
Bottom navigation for mobile added #150
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@MHamzaBham there are a couple of suggestions from qodo auto code review including syntax error. Could you please look into those? |
public/assets/css/custom.css
Outdated
transform: scale(1); | ||
} | ||
|
||
.transaction-add-button:hover { | ||
transform: scale(1.1); | ||
transition: 0.3s ease-in-out; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Improve animation smoothness
.transaction-add-button{ | |
transform: scale(1); | |
} | |
.transaction-add-button:hover { | |
transform: scale(1.1); | |
transition: 0.3s ease-in-out; | |
} | |
.transaction-add-button{ | |
transform: scale(1); | |
transition: 0.3s ease-in-out; | |
} | |
.transaction-add-button:hover { | |
transform: scale(1.1); | |
} |
Made the suggested changes |
PR Type
Enhancement
Description
Added a bottom navigation bar for mobile view.
Introduced hover effects for transaction add button.
Integrated a modal for adding/editing transactions.
Adjusted z-index for success toast for better visibility.
Changes walkthrough 📝
custom.css
Added hover effects for transaction add button
public/assets/css/custom.css
.transaction-add-button
..transaction-add-button
.dashboard.blade.php
Integrated modal for transaction add/edit functionality
resources/views/dashboard.blade.php
div
withid="modalDiv"
.navigation.blade.php
Added mobile bottom navigation bar
resources/views/layouts/navigation.blade.php
success-toast.blade.php
Adjusted z-index for success toast
resources/views/partials/success-toast.blade.php