Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More strict on what is considered a builtin - Fixes #16 #17

Merged
merged 5 commits into from
May 18, 2022
Merged

More strict on what is considered a builtin - Fixes #16 #17

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00148f4
Test case for issue 16
fbartho May 17, 2022
c9bc121
Simplify failing test case
IanVS May 17, 2022
495820a
Make builtin regex more strict
IanVS May 17, 2022
1ffec83
Allow `node:` prefix as well
IanVS May 17, 2022
a2476e0
Merge branch 'main' into fb/repro-cli-issue
fbartho May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const chunkTypeOther = 'other';
* where the not matched imports should be placed
*/
export const THIRD_PARTY_MODULES_SPECIAL_WORD = '<THIRD_PARTY_MODULES>';
export const BUILTIN_MODULES = builtinModules.join('|');
export const BUILTIN_MODULES = `^(?:${builtinModules.join('|')})$`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful, this is missing support for node protocol imports, e.g. require("node:fs")

`^(${builtinModules.join("|")}|${builtinModules.map(module => 'node:'+module).join("|")})$`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps a bit simpler:

`^(node:)?(${builtinModules.join("|")})$`

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have run all the tests before pushing it up. :)

I tweaked the regex a bit to allow an optional node: prefix.

This comment was marked as outdated.

Sign in to view

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I see the fix now)


const PRETTIER_PLUGIN_SORT_IMPORTS_NEW_LINE =
'PRETTIER_PLUGIN_SORT_IMPORTS_NEW_LINE';
Expand Down