Bug: Artifact threshold of 0.25 duplicate.

[bitozoid]

Describe the bug
The source code repeats '0.25' for artifact threshold. See links below.

FatMaxxer version number or name
This is about source code.

https://github.com/IanPeake/FatMaxxer/blob/main/app/src/main/java/online/fatmaxxer/publicRelease1/MainActivity.java#L2374

https://github.com/IanPeake/FatMaxxer/blob/main/app/src/main/java/online/fatmaxxer/publicRelease1/MainActivity.java#L2377

Comments

I was trying to get some insight about the "Auto" feature for the artifacts threshold, and found the bug.

Btw, is there any reference about why these values and why 'Auto' works that way? I get a very high drop rate, and I see too many artifacts when working out.

[IanPeake]

Thanks, I'll take a look. It may take me a few days to get to it. You also asked about the purpose of the Auto setting is to adjust the threshold based on some assumptions of normal rates of artifacts under different conditions. It sounds like you are asking to adjust the threshold to something other than 25% during workouts? Have you looked at saved ECG snippets to see whether the artifacts are caused by a faulty strap vs HR irregularities? Ian

…

On Tue, Sep 10, 2024 at 9:43 PM bitozoid ***@***.***> wrote: *Describe the bug* The source code repeats '0.25' for artifact threshold. See links below. *FatMaxxer version number or name* This is about source code. https://github.com/IanPeake/FatMaxxer/blob/main/app/src/main/java/online/fatmaxxer/publicRelease1/MainActivity.java#L2374 https://github.com/IanPeake/FatMaxxer/blob/main/app/src/main/java/online/fatmaxxer/publicRelease1/MainActivity.java#L2377 *Comments* I was trying to get some insight about the "Auto" feature for the artifacts threshold, and found the bug. Btw, is there any reference about why these values and why 'Auto' works that way? I get a very high drop level, and I see too many artifacts when working out. — Reply to this email directly, view it on GitHub <#46>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFSEU6OEAB333MC3O43AM33ZV3LM3AVCNFSM6AAAAABN6R6PPSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTMMRQGUZTMOI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[IanPeake]

Taking a quick look at the source, it does indeed look like a bug. I will double check what this looks like all my development box. Ian

…

On Thu, Sep 12, 2024 at 9:28 AM Ian Peake ***@***.***> wrote: Thanks, I'll take a look. It may take me a few days to get to it. You also asked about the purpose of the Auto setting is to adjust the threshold based on some assumptions of normal rates of artifacts under different conditions. It sounds like you are asking to adjust the threshold to something other than 25% during workouts? Have you looked at saved ECG snippets to see whether the artifacts are caused by a faulty strap vs HR irregularities? Ian On Tue, Sep 10, 2024 at 9:43 PM bitozoid ***@***.***> wrote: > *Describe the bug* > The source code repeats '0.25' for artifact threshold. See links below. > > *FatMaxxer version number or name* > This is about source code. > > > https://github.com/IanPeake/FatMaxxer/blob/main/app/src/main/java/online/fatmaxxer/publicRelease1/MainActivity.java#L2374 > > > https://github.com/IanPeake/FatMaxxer/blob/main/app/src/main/java/online/fatmaxxer/publicRelease1/MainActivity.java#L2377 > > *Comments* > > I was trying to get some insight about the "Auto" feature for the > artifacts threshold, and found the bug. > > Btw, is there any reference about why these values and why 'Auto' works > that way? I get a very high drop level, and I see too many artifacts when > working out. > > — > Reply to this email directly, view it on GitHub > <#46>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFSEU6OEAB333MC3O43AM33ZV3LM3AVCNFSM6AAAAABN6R6PPSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTMMRQGUZTMOI> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> >