Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Square root ising #76

Merged
merged 6 commits into from
Mar 28, 2023
Merged

Square root ising #76

merged 6 commits into from
Mar 28, 2023

Conversation

JoeyT1994
Copy link
Contributor

Added Functions to specialitensornetworks.jl for creating the Tensor Network State corresponding to the square root of the classical ising partition function.

Also:

i) Removed a repeated docstring.
ii) Specified the link_space argument in ising_network so it works for both an index network with siteinds and without.

@mtfishman
Copy link
Member

Thanks, nice to see that you can mostly make use of the existing ising_network function.

@mtfishman
Copy link
Member

@JoeyT1994 looks like this broke a BP test.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Merging #76 (f9916d5) into main (741a28f) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   77.79%   77.59%   -0.20%     
==========================================
  Files          61       61              
  Lines        3233     3241       +8     
==========================================
  Hits         2515     2515              
- Misses        718      726       +8     
Impacted Files Coverage Δ
src/specialitensornetworks.jl 71.87% <0.00%> (-10.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JoeyT1994
Copy link
Contributor Author

Okay I see. I fixed it now with the latest commit.

@mtfishman
Copy link
Member

mtfishman commented Mar 24, 2023

Maybe ising_network_state would be a better name? square_root doesn't seem quite right for this (it's more that it is a state such that the norm of the state gives the Ising model).

@mtfishman
Copy link
Member

Thanks Joey, this will be very nice to have!

@mtfishman mtfishman merged commit d0948e9 into ITensor:main Mar 28, 2023
@JoeyT1994 JoeyT1994 deleted the SquareRootIsing branch March 30, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants