-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor expect (single site) #162
Conversation
…nsorNetworks.jl into refactor_expect_simplified
@mtfishman I refactored As Let me know what you think |
Looks good, thanks! |
This PR refactors the
expect()
interface.expect(psi::AbstractITensorNetwork, op::Op)
now passes to theenvironment(f::AbstractFormNetwork, ...)
function introduced in PR #145 and thus allows theexpect()
function to have a choice of algorithmic backend, with"bp"
and"exact"
currently supported.Testing is added with
test_expect.jl
with some tests are removed fromtest_beliefpropagation.jl
to avoid added.Currently single-site expectation values are supported (so some tests which were computing two-site ones in
test_tebd.jl
have been temporarily disabled) but multi_site will be added in the near future.