Better Edge Tag Naming #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoeyT1994 some other improvements: vertex_tag(v) = replace("$v", "," => "×", "(" => "", ")" => "")on line 2 of is[v] = [siteind(sitetypes[v], vertex_tag(v); kwargs...)]on line 15 of |
|
Sure added them! |
mtfishman
reviewed
Jul 13, 2023
mtfishman
reviewed
Jul 13, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 79.29% 79.20% -0.10%
==========================================
Files 64 64
Lines 3512 3506 -6
==========================================
- Hits 2785 2777 -8
- Misses 727 729 +2
|
|
Okay I have mode those changes and all seems to be passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick PR to improve Edge tag naming and allow for longer tag names.
Should resolve Issue #78