[WIP] Rewrite based on NamedDimsArrays.jl
#108
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2025
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial attempt to rewrite
ITensorMPS.jlusing the newITensors.jlbeing developed here: ITensor/ITensors.jl#1611, which is based onNamedDimsArrays.jlandITensorBase.jl.Part of the goal is to determine which functionality we still need to implement in
ITensorBase.jlin order to getITensorMPS.jltests to pass (for example, tagging and priming aren't implemented yet).One of the biggest challenges will be rewriting QN-conserving
OpSumtoMPOconstruction, since theQNtype andBlockSparsestorage are being replaced by the new types introduced inSymmetrySectors.jlandBlockSparseArrays.jl. For now I'm just disabling that code so the package loads and I can test out non-QN functionality, we'll have to strategize about adding that back.