🎨 [Frontend] ViP Market: Cache pricing units #7248
Merged
+41
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
odeimaiz
requested review from
giancarloromeo,
ignapas,
GitHK,
pcrespov,
mguidon,
sanderegg and
matusdrobuliak66
pcrespov
approved these changes
Feb 19, 2025
|
GitHK
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In order to show the "Open Access Models", the pricing units of the pricing plans assigned to all licensedItems are required (those with a single pricing unit with cost 0 will fall in this category).
In this PR we cache the pricing units, making the population of the "Open Access Models" category faster and less stressful for the backend.
Before:
After:
Bonus
Related issue/s
How to test
Dev-ops checklist