-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ web-api: Empty bins for folders and its content #7237
✨ web-api: Empty bins for folders and its content #7237
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7237 +/- ##
==========================================
- Coverage 85.39% 83.64% -1.76%
==========================================
Files 1677 651 -1026
Lines 64805 31257 -33548
Branches 1115 177 -938
==========================================
- Hits 55343 26144 -29199
+ Misses 9144 5051 -4093
+ Partials 318 62 -256
Continue to review full report in Codecov by Sentry.
|
307786b
to
05ee408
Compare
05ee408
to
27dad9d
Compare
…osparc-simcore into is468/empty-trash-from-folders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff! Thanks for the effort
|
What do these changes do?
This PR enhances
empty_trash
to support folders, along with all their contents, including subfolders and projects. It also removes projects that were implicitly trashed.Support for workspaces and shared projects will be addressed in future PRs.
Related issue/s
How to test
Driving tests
Manual exploratory test
foo
foo
and move one project therebar
bar
and move another project therefoo
foo
Dev-ops
None