-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ VIP models introduce licensed versioning (🗃️) #7215
♻️ VIP models introduce licensed versioning (🗃️) #7215
Conversation
…o vip-models-split-licensed-items-2-attempt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7215 +/- ##
==========================================
- Coverage 87.02% 86.90% -0.13%
==========================================
Files 1654 1596 -58
Lines 64468 62888 -1580
Branches 1095 1005 -90
==========================================
- Hits 56106 54650 -1456
+ Misses 8049 7946 -103
+ Partials 313 292 -21
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/postgres-database/src/simcore_postgres_database/models/licensed_items.py
Show resolved
Hide resolved
...s-database/src/simcore_postgres_database/models/resource_tracker_licensed_items_checkouts.py
Show resolved
Hide resolved
...s-database/src/simcore_postgres_database/models/resource_tracker_licensed_items_purchases.py
Show resolved
Hide resolved
...ry/src/servicelib/rabbitmq/rpc_interfaces/resource_usage_tracker/licensed_items_checkouts.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/licenses/_licensed_items_rest.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/licenses/_licensed_items_service.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/licenses/_licensed_items_repository.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, but I would definitely strongly suggest to at least define the TypeAliases LicensedItemKey
and LicensedItemVersion
to prevent confusion with ServiceKey and ServiceVersion all over the place.
Also the minimum is a TypeAlias.
...ls-library/src/models_library/api_schemas_resource_usage_tracker/licensed_items_checkouts.py
Outdated
Show resolved
Hide resolved
...ls-library/src/models_library/api_schemas_resource_usage_tracker/licensed_items_purchases.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/licensed_items.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/licensed_items.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/licensed_items_checkouts.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/licensed_items_purchases.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/resource_tracker_licensed_items_purchases.py
Outdated
Show resolved
Hide resolved
...s-database/src/simcore_postgres_database/models/resource_tracker_licensed_items_purchases.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/model_adapter.py
Outdated
Show resolved
Hide resolved
...sage-tracker/src/simcore_service_resource_usage_tracker/services/licensed_items_checkouts.py
Outdated
Show resolved
Hide resolved
|
e35a13f
into
ITISFoundation:master
What do these changes do?
licensed_item_id
=key
+version
(unique)Next steps/improvements:
num_of_seats
field to be used for offering 1, 5 or 10 seats pricing options.Related issue/s
How to test
Dev-ops checklist