-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ web-api: exposes project's icon as an ui
attribute
#7204
✨ web-api: exposes project's icon as an ui
attribute
#7204
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7204 +/- ##
==========================================
- Coverage 87.06% 87.05% -0.01%
==========================================
Files 1646 1646
Lines 64297 64312 +15
Branches 1186 1186
==========================================
+ Hits 55977 55990 +13
- Misses 8008 8010 +2
Partials 312 312
Continue to review full report in Codecov by Sentry.
|
f4ede14
to
64599ef
Compare
ui
attribute
|
What do these changes do?
This PR introduces project icons. As outlined in #7158, the project icon is managed by the front end and is included in the
ui
field (credits to @giancarloromeo). This ensures transparency for the backend, which only validates and stores the data. It also simplifies implementation by avoiding the need for an additional database column, unlike services—though services could also potentially use aui
column.Some details of the implementation
create_project
projects.ui
modelsProjectDB
->ProjectDBGet
to stress that it is a model that reads from the dbRelated issue/s
How to test
Driving test: ``
Dev-ops