-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Services metadata has icon field and API can get/update it 🗃️ #7174
🎨 Services metadata has icon field and API can get/update it 🗃️ #7174
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7174 +/- ##
==========================================
+ Coverage 87.70% 87.75% +0.05%
==========================================
Files 1641 1635 -6
Lines 64177 64041 -136
Branches 1179 1179
==========================================
- Hits 56286 56201 -85
+ Misses 7580 7529 -51
Partials 311 311
Continue to review full report in Codecov by Sentry.
|
b661610
to
9acdf21
Compare
9acdf21
to
8af4eb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! thanks!
packages/models-library/src/models_library/services_metadata_editable.py
Show resolved
Hide resolved
|
What do these changes do?
web


catalog
Any service meta-data now defines an optional
icon
field to store a url for the service icon. This is exposed to the front-end via theweb-api
(v0.54.0
) under/catalog/services
. Note that this is NOT exposed to thepublic-api
soSolver
resource does not include anicon
.Details
icon
column inservices_meta_data
tablecatalog
models by usingDBGet
,DBPath
andDBCreate
suffixescatalog
API schemas (v0.8.0
)icon
field toServiceGetV2``ServiceUpdateV2
schemaswebserver
API schemas (v0.54.0
)icon
field toCatalogServiceGet
/CatalogServiceUpdate
schemasRelated issue/s
How to test
Dev-ops
NOne