-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Update traefik router hardcoded priorities #7141
♻️ Update traefik router hardcoded priorities #7141
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7141 +/- ##
==========================================
+ Coverage 87.69% 87.72% +0.02%
==========================================
Files 1635 1628 -7
Lines 63875 63685 -190
Branches 1173 1173
==========================================
- Hits 56015 55866 -149
+ Misses 7550 7510 -40
+ Partials 310 309 -1
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you know what you are doing ;)
What do these changes do?
manual
serviceThis PR introduces some space in-between the routers which we can use to flexibly add new routers. It shouldn't break existing priority hierarchy since numbers <10 are still below any other non-hardcoded priorities.
Remarks for future:
Related issue/s
Related PRs
How to test
Dev-ops checklist