Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Frontend] Bugfix: Do not recreate login page after resize #7118

Merged
merged 7 commits into from
Jan 29, 2025
Merged

🐛 [Frontend] Bugfix: Do not recreate login page after resize #7118

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4324322
Do not recreate login page
odeimaiz Jan 28, 2025
40a58cb
minor
odeimaiz Jan 28, 2025
a6663c2
Merge branch 'master' into fix/do-not-recreate-loginpage
odeimaiz Jan 28, 2025
bfbb63f
Merge branch 'fix/do-not-recreate-loginpage' of github.com:odeimaiz/o…
odeimaiz Jan 28, 2025
a0d14b6
Merge branch 'master' into fix/do-not-recreate-loginpage
mergify[bot] Jan 28, 2025
194d027
Merge branch 'master' into fix/do-not-recreate-loginpage
odeimaiz Jan 28, 2025
e6d3e35
Merge branch 'master' into fix/do-not-recreate-loginpage
odeimaiz Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions services/static-webserver/client/source/class/osparc/auth/LoginPageSplit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ qx.Class.define("osparc.auth.LoginPageSplit", {
const layout = new qx.ui.layout.HBox();
this._setLayout(layout);

const loginPage = this.__loginPage = new osparc.auth.LoginWithDecorators();
loginPage.addListener("done", e => this.fireDataEvent("done", e.getData()));

this.__rebuildLayout();

setTimeout(() => this.__resized(), 100);
Expand All @@ -51,6 +54,8 @@ qx.Class.define("osparc.auth.LoginPageSplit", {
},

members: {
__loginPage: null,

_getBackgroundImage: function() {
throw new Error("Abstract method called!");
},
Expand All @@ -67,8 +72,7 @@ qx.Class.define("osparc.auth.LoginPageSplit", {
__rebuildLayout: function() {
this._removeAll();

const loginPage = new osparc.auth.LoginWithDecorators();
loginPage.addListener("done", e => this.fireDataEvent("done", e.getData()));
const loginPage = this.__loginPage;
const container = new qx.ui.container.Scroll();
container.add(loginPage);
const spacers = [
Expand Down
Loading