-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 remove noisy errors form logs #7094
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7094 +/- ##
==========================================
+ Coverage 87.26% 88.52% +1.25%
==========================================
Files 1634 1126 -508
Lines 64264 49123 -15141
Branches 2051 262 -1789
==========================================
- Hits 56082 43485 -12597
+ Misses 7845 5578 -2267
+ Partials 337 60 -277
Continue to review full report in Codecov by Sentry.
|
packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GitHK Q: We do not use S3 CLI, how did you find out that this needs modification?
@matusdrobuliak66 I was investigating tests for an upgrade that how I found out. Also @giancarloromeo showed this to me last week |
packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py
Outdated
Show resolved
Hide resolved
|
What do these changes do?
While per se this only generates tracebacks which have no impact on the functionality. It is creates noise when trying to check errors.
This fixes the below issue. ByteSize does not know what
Bytes
are. It only knows aboutb
and omitting the word bytes if they are just bytes.Related issue/s
How to test
Dev-ops checklist