Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 remove noisy errors form logs #7094

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 27, 2025

What do these changes do?

While per se this only generates tracebacks which have no impact on the functionality. It is creates noise when trying to check errors.

This fixes the below issue. ByteSize does not know what Bytes are. It only knows about b and omitting the word bytes if they are just bytes.

2025-01-27 09:31:32 ERROR Unhandled exception:
Traceback (most recent call last):
  File "/home/runner/work/osparc-simcore/osparc-simcore/.venv/lib/python3.11/site-packages/servicelib/logging_utils.py", line 383, in log_catch
    yield
  File "/home/runner/work/osparc-simcore/osparc-simcore/.venv/lib/python3.11/site-packages/simcore_sdk/node_ports_common/aws_s3_cli_utils.py", line 38, in __call__
    _bytes = TypeAdapter(ByteSize).validate_python(_size)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/osparc-simcore/osparc-simcore/.venv/lib/python3.11/site-packages/pydantic/type_adapter.py", line 412, in validate_python
    return self.validator.validate_python(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pydantic_core._pydantic_core.ValidationError: 1 validation error for function-after[_validate(), union[constrained-str,constrained-int]]
  could not interpret byte unit: Bytes [type=byte_size_unit, input_value='10 Bytes', input_type=str]

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jan 27, 2025
@GitHK GitHK added the t:maintenance Some planned maintenance work label Jan 27, 2025
@GitHK GitHK added this to the Singularity milestone Jan 27, 2025
@GitHK GitHK changed the title log error cleanup 🐛 remove noisy errors form logs Jan 27, 2025
@GitHK GitHK marked this pull request as ready for review January 27, 2025 09:49
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.52%. Comparing base (69cf7cb) to head (8136e6c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7094      +/-   ##
==========================================
+ Coverage   87.26%   88.52%   +1.25%     
==========================================
  Files        1634     1126     -508     
  Lines       64264    49123   -15141     
  Branches     2051      262    -1789     
==========================================
- Hits        56082    43485   -12597     
+ Misses       7845     5578    -2267     
+ Partials      337       60     -277     
Flag Coverage Δ
integrationtests 64.77% <100.00%> (-0.01%) ⬇️
unittests 86.21% <0.00%> (+0.71%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <100.00%> (ø)
agent 96.45% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.10% <ø> (ø)
catalog 90.32% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.92% <ø> (ø)
director_v2 91.30% <ø> (+0.02%) ⬆️
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.39% <ø> (ø)
invitations 93.42% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.28% <ø> (ø)
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.92% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69cf7cb...8136e6c. Read the comment docs.

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitHK Q: We do not use S3 CLI, how did you find out that this needs modification?

@GitHK
Copy link
Contributor Author

GitHK commented Jan 27, 2025

@GitHK Q: We do not use S3 CLI, how did you find out that this needs modification?

@matusdrobuliak66 I was investigating tests for an upgrade that how I found out. Also @giancarloromeo showed this to me last week

@GitHK GitHK enabled auto-merge (squash) January 27, 2025 12:18
@GitHK GitHK merged commit fb86798 into ITISFoundation:master Jan 27, 2025
90 of 93 checks passed
@GitHK GitHK deleted the pr-osparc-fix-parsing branch January 27, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants