Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix not listing published templates #7065

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • 🐛 By default we show both published and not published templates.

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jan 21, 2025
@matusdrobuliak66 matusdrobuliak66 added bug buggy, it does not work as expected a:webserver issue related to the webserver service labels Jan 21, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review January 21, 2025 15:22
@matusdrobuliak66 matusdrobuliak66 added this to the Singularity milestone Jan 21, 2025
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.49%. Comparing base (da83fb7) to head (b0dbbe0).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (da83fb7) and HEAD (b0dbbe0). Click for more details.

HEAD has 26 uploads less than BASE
Flag BASE (da83fb7) HEAD (b0dbbe0)
unittests 30 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7065      +/-   ##
==========================================
- Coverage   87.25%   81.49%   -5.76%     
==========================================
  Files        1634      689     -945     
  Lines       64261    33947   -30314     
  Branches     2050      262    -1788     
==========================================
- Hits        56070    27665   -28405     
+ Misses       7854     6222    -1632     
+ Partials      337       60     -277     
Flag Coverage Δ
integrationtests 64.77% <ø> (+0.47%) ⬆️
unittests 84.81% <ø> (-0.73%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.68% <ø> (-12.63%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.59% <ø> (-0.16%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 81.53% <ø> (-3.41%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da83fb7...b0dbbe0. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a test would be nice

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) January 22, 2025 08:45
@matusdrobuliak66 matusdrobuliak66 merged commit abbddb3 into ITISFoundation:master Jan 22, 2025
89 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Published TEMPLATES are not visible in templates tab
6 participants