Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] e2e: Add test ids to version selector in Service Browser #7060

Merged
merged 9 commits into from
Jan 21, 2025
Merged

🎨 [Frontend] e2e: Add test ids to version selector in Service Browser #7060

merged 9 commits into from
Jan 21, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 20, 2025 •
edited
Loading

What do these changes do?

osparc-test-id='serviceSelectBox' for the box and osparc-test-id='serviceVersionItem_$version' for the selectable items.

image

Bonus

  • Make support emails easier to be selected

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz changed the title 🎨 [Frontend] e2e: add Enh/e2e ids 🎨 [Frontend] e2e: Add test ids to version selector in Service Browser Jan 20, 2025
@odeimaiz odeimaiz marked this pull request as ready for review January 20, 2025 13:03
@odeimaiz odeimaiz enabled auto-merge (squash) January 20, 2025 13:03
@odeimaiz odeimaiz self-assigned this Jan 20, 2025
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing labels Jan 20, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Jan 20, 2025
@odeimaiz odeimaiz requested a review from sanderegg January 20, 2025 13:08
@odeimaiz odeimaiz disabled auto-merge January 20, 2025 13:31
@odeimaiz odeimaiz enabled auto-merge (squash) January 20, 2025 13:31
sanderegg
sanderegg reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@odeimaiz odeimaiz disabled auto-merge January 21, 2025 12:34
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit 272671c into ITISFoundation:master Jan 21, 2025
55 of 61 checks passed
@odeimaiz odeimaiz deleted the enh/e2e-ids branch January 21, 2025 14:37
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 30, 2025
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@ignapas ignapas ignapas approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Singularity
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @ignapas @sanderegg @matusdrobuliak66