Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix pylint tests #7056

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jan 17, 2025

What do these changes do?

  • install docker python package and fix pylint complaints after pylint upgrade

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Jan 17, 2025
@bisgaard-itis bisgaard-itis added this to the Singularity milestone Jan 17, 2025
@bisgaard-itis bisgaard-itis changed the title 🐛 Fix pylint complaints 🐛 Fix pylint tests Jan 17, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) January 20, 2025 08:32
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.64%. Comparing base (3d01781) to head (238b295).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7056      +/-   ##
==========================================
+ Coverage   87.57%   88.64%   +1.07%     
==========================================
  Files        1629     1356     -273     
  Lines       63454    55335    -8119     
  Branches     2047     1042    -1005     
==========================================
- Hits        55569    49051    -6518     
+ Misses       7549     6123    -1426     
+ Partials      336      161     -175     
Flag Coverage Δ
integrationtests 63.76% <ø> (-0.01%) ⬇️
unittests 86.79% <28.57%> (+0.83%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.45% <0.00%> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.02% <100.00%> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library 90.49% <100.00%> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.45% <ø> (ø)
api_server 90.54% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.66% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.42% <ø> (-0.09%) ⬇️
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.46% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.46% <ø> (ø)
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 85.94% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d01781...238b295. Read the comment docs.

@sanderegg sanderegg disabled auto-merge January 20, 2025 10:41
@sanderegg sanderegg merged commit 73c3b1c into ITISFoundation:master Jan 20, 2025
88 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants