-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚑️ Added escaping for 7zip paths #7049
🚑️ Added escaping for 7zip paths #7049
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7049 +/- ##
==========================================
- Coverage 86.94% 86.74% -0.21%
==========================================
Files 1651 1293 -358
Lines 64839 54986 -9853
Branches 2043 1010 -1033
==========================================
- Hits 56374 47695 -8679
+ Misses 8130 7097 -1033
+ Partials 335 194 -141
Continue to review full report in Codecov by Sentry.
|
Co-authored-by: Andrei Neagu <[email protected]>
What do these changes do?
Paths were not at all escaped. Added escaping via
shlex.quote
. This should cover all possible cases with all the paths involving 7zip: achieve names, destination folder, source folderJust the
dynamic-sidecar
image is required for this hot to work. Requiresdirector-v2
� reboot.Related issue/s
How to test
Dev-ops checklist