Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑️ Added escaping for 7zip paths #7049

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 16, 2025

What do these changes do?

Paths were not at all escaped. Added escaping via shlex.quote. This should cover all possible cases with all the paths involving 7zip: achieve names, destination folder, source folder

⚠️ Hotfix instructions

Just the dynamic-sidecar image is required for this hot to work. Requires director-v2� reboot.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jan 16, 2025
@GitHK GitHK added bug buggy, it does not work as expected High Priority a totally crucial bug/feature to be fixed asap t:maintenance Some planned maintenance work labels Jan 16, 2025
@GitHK GitHK added this to the Singularity milestone Jan 16, 2025
@GitHK GitHK marked this pull request as ready for review January 16, 2025 13:14
@GitHK GitHK requested a review from pcrespov as a code owner January 16, 2025 13:14
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (eac9d86) to head (d1acae3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7049      +/-   ##
==========================================
- Coverage   86.94%   86.74%   -0.21%     
==========================================
  Files        1651     1293     -358     
  Lines       64839    54986    -9853     
  Branches     2043     1010    -1033     
==========================================
- Hits        56374    47695    -8679     
+ Misses       8130     7097    -1033     
+ Partials      335      194     -141     
Flag Coverage Δ
integrationtests 64.45% <ø> (+0.64%) ⬆️
unittests 85.47% <100.00%> (-0.32%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 73.89% <100.00%> (+<0.01%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.45% <ø> (ø)
api_server 90.54% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.66% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.42% <ø> (-0.09%) ⬇️
director_v2 91.31% <ø> (+0.02%) ⬆️
dynamic_scheduler 97.20% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.46% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.52% <ø> (+0.17%) ⬆️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.06% <ø> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac9d86...d1acae3. Read the comment docs.

@mrnicegyu11 mrnicegyu11 merged commit 2460775 into ITISFoundation:master Jan 16, 2025
91 of 93 checks passed
@GitHK GitHK deleted the pr-osparc-hotfix-zipping branch January 16, 2025 14:16
matusdrobuliak66 pushed a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected High Priority a totally crucial bug/feature to be fixed asap t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants