-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Frontend] ViP Rentals and ViP Checkouts in Billing Center #7043
✨ [Frontend] ViP Rentals and ViP Checkouts in Billing Center #7043
Conversation
…mcore into feature/rentals-table
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7043 +/- ##
==========================================
- Coverage 86.17% 82.90% -3.27%
==========================================
Files 1629 687 -942
Lines 63454 33296 -30158
Branches 2047 262 -1785
==========================================
- Hits 54681 27604 -27077
+ Misses 8437 5632 -2805
+ Partials 336 60 -276
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2 Rappen:
- Sections should not have repeated icons
- Can purchases and usage be merged together?
- As an unfamiliar user, I have no clue of what a checkout could be
As mentioned in the PR, this is a first iteration, PoC if you like, and it won't go further than master
|
|
What do these changes do?
First iteration on listing in a table the
licensed-items-purchases
andlicensed-items-checkouts
Related issue/s
How to test
Dev-ops checklist