Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Frontend] ViP Rentals and ViP Checkouts in Billing Center #7043

Merged
merged 41 commits into from
Jan 17, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 14, 2025

What do these changes do?

First iteration on listing in a table the licensed-items-purchases and licensed-items-checkouts

  • ViP Purchases
  • ViP Checkouts
  • ViP Store (catalog and licensed-items)

LicensedItems

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added this to the Singularity milestone Jan 14, 2025
@odeimaiz odeimaiz self-assigned this Jan 14, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jan 14, 2025
@odeimaiz odeimaiz changed the title ✨ [Frontend] Rentals in Billing Center ✨ [Frontend] ViP Rentals and ViP usages in Billing Center Jan 14, 2025
@odeimaiz odeimaiz marked this pull request as ready for review January 15, 2025 16:32
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.90%. Comparing base (17f3111) to head (3466907).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7043      +/-   ##
==========================================
- Coverage   86.17%   82.90%   -3.27%     
==========================================
  Files        1629      687     -942     
  Lines       63454    33296   -30158     
  Branches     2047      262    -1785     
==========================================
- Hits        54681    27604   -27077     
+ Misses       8437     5632    -2805     
+ Partials      336       60     -276     
Flag Coverage Δ
integrationtests 64.84% <50.00%> (-0.03%) ⬇️
unittests 84.93% <100.00%> (+0.70%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.61% <ø> (-12.70%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.59% <ø> (-0.16%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 83.74% <100.00%> (+2.49%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f3111...3466907. Read the comment docs.

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 2 Rappen:

  • Sections should not have repeated icons
  • Can purchases and usage be merged together?
  • As an unfamiliar user, I have no clue of what a checkout could be

@odeimaiz
Copy link
Member Author

odeimaiz commented Jan 16, 2025

My 2 Rappen:

  • Sections should not have repeated icons
  • Can purchases and usage be merged together?
  • As an unfamiliar user, I have no clue of what a checkout could be

As mentioned in the PR, this is a first iteration, PoC if you like, and it won't go further than master

  • we want it deployed so that POs see something and then can give feedback, that's why we don't care about aesthetics yet
  • purchases and checkouts show different content in their tables, that's why they go, for now, in different sections
  • "purchases" show the "rentals/payments" of ViP models that can be used in the rocket, while "checkouts/usage" show when and where the ViP models were used

@odeimaiz odeimaiz enabled auto-merge (squash) January 16, 2025 17:36
@odeimaiz odeimaiz merged commit 9c1e764 into ITISFoundation:master Jan 17, 2025
88 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants