Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 extend ooil to support depends_on keyword in overwrites #7041

Merged
merged 17 commits into from
Jan 23, 2025

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 14, 2025

What do these changes do?

When building some services like https://github.com/ITISFoundation/ML-TensorFlow-application it is mandatory that certain build job are concluded before start. With the depends_on keyword it is now possible to do so.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jan 14, 2025
@GitHK GitHK added this to the Singularity milestone Jan 14, 2025
@GitHK GitHK added t:maintenance Some planned maintenance work a:ooil integration-library or ooil t:enhancement Improvement or request on an existing feature labels Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.84%. Comparing base (a4e0406) to head (becf4ae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7041      +/-   ##
==========================================
+ Coverage   87.26%   88.84%   +1.57%     
==========================================
  Files        1634     1312     -322     
  Lines       64259    54567    -9692     
  Branches     2050      904    -1146     
==========================================
- Hits        56076    48478    -7598     
+ Misses       7846     5952    -1894     
+ Partials      337      137     -200     
Flag Coverage Δ
integrationtests 64.74% <ø> (+0.47%) ⬆️
unittests 86.83% <77.50%> (+1.32%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.43% <37.50%> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.18% <87.50%> (+0.15%) ⬆️
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.50% <ø> (+0.11%) ⬆️
agent 96.45% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.32% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.92% <ø> (ø)
director_v2 91.25% <ø> (-0.05%) ⬇️
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (-0.04%) ⬇️
efs_guardian 90.39% <ø> (ø)
invitations 93.42% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.17% <ø> (+0.11%) ⬆️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.16% <ø> (+1.24%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e0406...becf4ae. Read the comment docs.

@GitHK GitHK marked this pull request as ready for review January 15, 2025 12:53
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx.

@GitHK GitHK enabled auto-merge (squash) January 15, 2025 14:46
@GitHK GitHK merged commit c37d45b into ITISFoundation:master Jan 23, 2025
90 of 93 checks passed
@GitHK GitHK deleted the pr-osparc-ooil-extensions branch January 23, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:ooil integration-library or ooil t:enhancement Improvement or request on an existing feature t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants