Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Infra: Build for arm64 #6984

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 19, 2024

What do these changes do?

In order to run oSparc on ARM-based processors, this PR allows to build docker images for ARM64 processors
This is useful for cost reduction purposes

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Dec 19, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Dec 19, 2024
@sanderegg sanderegg self-assigned this Dec 19, 2024
@sanderegg sanderegg marked this pull request as draft December 19, 2024 16:31
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.08%. Comparing base (493488c) to head (d6f9aa5).

❗ There is a different number of reports uploaded between BASE (493488c) and HEAD (d6f9aa5). Click for more details.

HEAD has 32 uploads less than BASE
Flag BASE (493488c) HEAD (d6f9aa5)
unittests 29 2
integrationtests 6 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6984       +/-   ##
===========================================
- Coverage   85.61%   68.08%   -17.54%     
===========================================
  Files        1621      670      -951     
  Lines       63993    32214    -31779     
  Branches     2035      262     -1773     
===========================================
- Hits        54789    21933    -32856     
- Misses       8871    10221     +1350     
+ Partials      333       60      -273     
Flag Coverage Δ
integrationtests 42.93% <ø> (-21.66%) ⬇️
unittests 78.02% <ø> (-6.38%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent 96.82% <ø> (ø)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.99% <ø> (-12.43%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.21% <ø> (-20.69%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493488c...d6f9aa5. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder whether we should also have some of those for development

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reassign when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants