Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Introduce license item checkout & release functionality (🗃️) #6960

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Dec 13, 2024

What do these changes do?

  • ✨ Introduce license item checkout & release functionality

    • When license item is checkout a checkout ID is returned
    • On the release the checkout ID needs to be provided
    • API server <--> Webserver <--> RUT is wired (Api server needs to be exposed @bisgaard-itis )
  • 🗃️♻️ Rename licensed_items_usages --> licensed_items_checkouts with checkout_id

  • BONUS:

    • 🐛 Rename text in exception: wallet -> credit account (for frontend)
    • 🐛 Fix export usage CSV
    • 🐛 Improve playwright e2e platform tests

NEXT STEPS:

  • Background task to release seats in case of service not running anymore

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 added a:webserver issue related to the webserver service a:resource-usage-tracker resource usage tracker service labels Dec 13, 2024
@matusdrobuliak66 matusdrobuliak66 self-assigned this Dec 13, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 71.34146% with 94 lines in your changes missing coverage. Please review.

Project coverage is 86.58%. Comparing base (f7e3e86) to head (69b0dcd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6960      +/-   ##
==========================================
- Coverage   87.06%   86.58%   -0.49%     
==========================================
  Files        1611     1556      -55     
  Lines       63632    62162    -1470     
  Branches     2027     1778     -249     
==========================================
- Hits        55400    53820    -1580     
- Misses       7898     8033     +135     
+ Partials      334      309      -25     
Flag Coverage Δ
integrationtests 64.90% <65.71%> (+0.02%) ⬆️
unittests 85.68% <71.34%> (+0.33%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.45% <100.00%> (+0.08%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.26% <100.00%> (ø)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 73.29% <0.00%> (-0.85%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.41% <ø> (ø)
dynamic_scheduler 97.14% <ø> (ø)
dynamic_sidecar 89.75% <ø> (+0.03%) ⬆️
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.97% <83.81%> (-0.62%) ⬇️
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 83.48% <100.00%> (-0.91%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e3e86...69b0dcd. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: ✨ Introduce vip models pricing 6 part ✨ Introduce vip models pricing 6 part (🗃️) Dec 17, 2024
@matusdrobuliak66 matusdrobuliak66 changed the title ✨ Introduce vip models pricing 6 part (🗃️) ✨ Introduce license item checkout & release functionality (🗃️) Dec 17, 2024
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci 👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Just it would be cooler if you have separate PRs with separate concerns. these were a lot of bonuses and it makes more complicated to understand separate things.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) December 18, 2024 10:28
@matusdrobuliak66 matusdrobuliak66 merged commit 5786896 into ITISFoundation:master Dec 18, 2024
88 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:resource-usage-tracker resource usage tracker service a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants