-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 expose service_run_id
as an env var for both comp and new style dynamic services
#6942
🎨 expose service_run_id
as an env var for both comp and new style dynamic services
#6942
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6942 +/- ##
==========================================
- Coverage 87.00% 86.87% -0.14%
==========================================
Files 1621 1451 -170
Lines 63942 60160 -3782
Branches 2033 1644 -389
==========================================
- Hits 55632 52262 -3370
+ Misses 7976 7628 -348
+ Partials 334 270 -64
Continue to review full report in Codecov by Sentry.
|
…ser-services-to-request-dy-sidecar-run-id
…-id' of github.com:GitHK/osparc-simcore-forked into pr-osparc-allow-user-services-to-request-dy-sidecar-run-id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but wrong computational run id
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_dask.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments
services/director-v2/src/simcore_service_director_v2/modules/dask_client.py
Outdated
Show resolved
Hide resolved
…ser-services-to-request-dy-sidecar-run-id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m fine with this unification 👍, but are we 100% sure that the concept of a run ID is the same in all three use cases: computation, dynamic, and resource usage tracker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me but please check my comments about the naming, and at least use import RunID as ServiceRunID in all the computational related modules in dv-2.
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_base.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_base.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_base.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_dask.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_dask.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_dask.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/dask_client.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/utils/dask.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please reassign back when unblocked. thx
…ser-services-to-request-dy-sidecar-run-id
service_run_id
as an env var for both comp and new style dynamic services
…ser-services-to-request-dy-sidecar-run-id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
services/director-v2/src/simcore_service_director_v2/modules/osparc_variables/substitutions.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
…ser-services-to-request-dy-sidecar-run-id
Quality Gate passedIssues Measures |
What do these changes do?
NOTE: this became very noisy due to a rename and unification of the names
The
${OSPARC_VARIABLE_SERVICE_RUN_ID}
will now be replaced in the compose spec with the actualservice_run_id
.The
service_run_id
must be exposed for both comp and dynamic services it's a requirement for some comp services.Bonus: unified
service_run_id
under one typeServiceRunID
shared by all servicesRelated issue/s
How to test
Dev-ops checklist