-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️♻️ WIP: Fixes openapi generators for web-api, i.e. api/specs/web-server #6771
⬆️♻️ WIP: Fixes openapi generators for web-api, i.e. api/specs/web-server #6771
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6771 +/- ##
===============================================================================
- Coverage 88.40% 84.83% -3.58%
===============================================================================
Files 1545 1254 -291
Lines 61635 53145 -8490
Branches 2100 885 -1215
===============================================================================
- Hits 54490 45084 -9406
- Misses 6817 7926 +1109
+ Partials 328 135 -193
Continue to review full report in Codecov by Sentry.
|
c60cd46
to
d513280
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not completely sure I understand what you are trying to do here. especially the Jsonstr and the comments in openapi.py
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, you need to explain me which of these changes fixed the open api specs for folder ID from int -> int | none
What do these changes do?
< ---- FIXME: Invalid args for response field! Hint: check that <class 'models_library.api_schemas_webserver.catalog.ServiceResourcesGet'> is a valid Pydantic field type
<--- FIXME: :TypeError: unhashable type: 'ClusterAccessRights'
<--- FIXME: RuntimeWarning: fields may not start with an underscore, ignoring "_file"
Json
for pydantic v2?Related issue/s