Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Refactor storage setup functions to avoid errors #6686

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 7, 2024

What do these changes do?

Added more logs to be able to better track what is happening during the setup.
Also fixed na issue where the yield would be swallowed in case of error.

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (d904673) to head (21a15d5).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (d904673) and HEAD (21a15d5). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (d904673) HEAD (21a15d5)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6686       +/-   ##
===========================================
- Coverage   87.92%   66.25%   -21.68%     
===========================================
  Files        1564      646      -918     
  Lines       62988    32685    -30303     
  Branches     2106      265     -1841     
===========================================
- Hits        55384    21656    -33728     
- Misses       7279    10968     +3689     
+ Partials      325       61      -264     
Flag Coverage Δ
integrationtests 64.84% <ø> (+0.02%) ⬆️
unittests 89.76% <100.00%> (+3.87%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.39% <ø> (-14.42%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.79% <ø> (-30.01%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.68% <ø> (-5.47%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 89.76% <100.00%> (+0.01%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.80% <ø> (-29.49%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d904673...21a15d5. Read the comment docs.

@GitHK GitHK marked this pull request as ready for review November 7, 2024 12:21
@GitHK GitHK requested a review from sanderegg as a code owner November 7, 2024 12:21
Copy link

sonarqubecloud bot commented Nov 7, 2024

@GitHK GitHK enabled auto-merge (squash) November 8, 2024 06:06
@GitHK GitHK merged commit 927319c into ITISFoundation:master Nov 8, 2024
84 of 89 checks passed
@GitHK GitHK deleted the pr-osparc-fix-storage-setup branch November 8, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants