Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] UX: Organization member's management #6676

Merged
merged 12 commits into from
Nov 6, 2024
Merged

🎨 [Frontend] UX: Organization member's management #6676

merged 12 commits into from
Nov 6, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 6, 2024 •
edited
Loading

What do these changes do?

  • Add new member field: helper text depends on user's role
  • Add new member field: always visible, it will be enabled/disabled depending on the role
  • Show member's role in the list. Users with no-add-member permission need to contact the Admin or Manager, therefore showing the role can be helpful

requested by @mrnicegyu11

OrgManagement

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 6, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Nov 6, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 6, 2024
@odeimaiz odeimaiz marked this pull request as ready for review November 6, 2024 13:08
mrnicegyu11
mrnicegyu11 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it thanks a lot

@odeimaiz odeimaiz enabled auto-merge (squash) November 6, 2024 14:05
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz merged commit 2972184 into ITISFoundation:master Nov 6, 2024
51 checks passed
This was referenced Nov 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@GitHK GitHK Awaiting requested review from GitHK

@pcrespov pcrespov Awaiting requested review from pcrespov

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @ignapas @mrnicegyu11 @matusdrobuliak66